File Listing

[MrProtoman]

Okay, so I'm bored and decided to add some files to my website for my amusement. I went looking through my archived PHP tutorials and found one for listing file info from a directory, so I'm putting it to work in my downloads directory, which is just where I upload random crap to give to someone else. Everything was going well, until I started trying to add more to it. Here's the code:

PHP Code:

<?php
$path = "downloads/"; 
$dir_handle = @opendir($path) or die("Unable to open $path"); 
while ($file = readdir($dir_handle)) { 
if(!is_dir($file)) { 
$filesize = round(filesize($path.$file)/131072, 2);
$mimetype = mime_content_type($path.$file);
echo "Name: $file<br>File Size: [ $filesize MB ]<br>Mime: $mimetype<br><a href=$path$file>Download file</a><br>------<br>"; 
} 
} 
closedir($dir_handle); 
?>

and the output:

application/x-zip Name: invboard1_2f.zip
File Size: [ 9.66 MB ]
Mime: application/x-zip
Download file
------

Now the part that's bugging me is the mime type displaying before Name:. Nothing should appear before that the way I understand it, because it's the only output/display type line. Everything else is function or alias asignment. While I can see why it would show before Name, I can't figure out why it's showing up at all. It's the in the same format as the alias above it. The only other thing in the file is the mime_content_type function because the actual PHP function of the same name doesn't work correctly on my server. I actually pulled this off the PHP.net comments about the function itself as a "if your function errors out, use this to simulate it instead" kind of thing.

PHP Code:

if ( ! function_exists ( 'mime_content_type ' ) )
{
   function mime_content_type ( $f )
   {
       return system ( trim( 'file -bi ' . escapeshellarg ( $f ) ) );
   }
} 


Looking at the preview before I post this, it apprears that the PHP bbcode tag parser agrees with Notepad++. There isn't anything missing from the code to mess it up. Any ideas?

[sneeuwbal]

think you left a space to much in the f construction

PHP Code:

if ( ! function_exists ( 'mime_content_type ' ) ) 


should be

PHP Code:

if ( ! function_exists ( 'mime_content_type' ) ) 


it does the trick for me so
or atleast it removes some of the errors that i get, still no value for the mime type though

[MrProtoman]

I'd actually already changed that in an attempt to fix it, though like I said, it came straight from some guy on the PHP.net page about that function. I went as far as skipping the variable and just calling the function where I need it in the code, but it still gives me two reports (Mime: application/x-zip application/x-zip).

I've since switched to a almost 200 line code to replace the above posted 7 that just compares the extension to a array of known extensions and their mime types, but I'd kind of like to know what's wrong with that one. Mine is more flexible, because I can add non-standard mime types like application/x-rar-compression for .RAR archives, and audio/x-ms-wmv for .WMV movies.

[kshok]

theres a nice apache extensions out there: mod_dir

[MrProtoman]

It's a little hard to configure the layout/design of the default directory listing from mod_autoindex when you don't have root access to the server, or any kind of shell/ssh access for that matter.